Temple+ Modding Question

OK Cool. I'll take 857 for improved favored enemy.

But is there really a need for a new bonus type or could I just go with type 0 which stacks with everything?

 

Most of the time you can use 0, yes.

 

Cool. I'll just go with 0 then. I suppose I need to reserve a bonus number in the future if there are stacking concerns?

 

Yes. I can reserve a range for you, e.g. 100-150.

 

OK cool. 100 to 150 (or whatever you think is best) sounds good to me.

 

Done! Let me know if/when you use any.

 

Next Question: Is there a way to use the TempleFix class replaceFunction method so that the replacing function calls the original version of the function. Something like:

replaceFunction(0xDEADBEEF, MyFix);

....

int MyFix(DispatcherCallbackArgs args)
{
//Do Some Stuff
CallOriginalVersion()
//Do some other stuff
}

 

Yes.
https://github.com/GrognardsFromHel...e.dll-Functions-and-Replacing-Arbitrary-Bytes
It's convenient to just declare the org function pointer as a static variable.

Also, please make sure the function you want to replace hasn't already been replaced

 

Thank You! Somehow I missed that it returns a callable version of the old function. I should be able to do what I wanted now.

 

Removing those calls in initClass broke my python extenders. For example, extra smiting stopped working.

However if I make the following change to initFeats things start working again:

if (_GetCondStructFromFeat(featList, &cond, &arg))
{
//_ConditionAddToAttribs_NumArgs2(dispatcher, cond, featList, arg);
_ConditionAddToAttribs_NumArgs2(dispatcher, conds.GetByName(cond->condName), featList, arg);
}

It seems like _GetCondStructFromFeat is returning an incorrect condition. Any thoughts on how I can fix this correctly?

BTW: Good find on those wrong BAB values. Should the BAB always be checked by the text file even if a python script is used?

 

Ah, you didn't do a MapToFeat on the extended feat. That's the reason why it's not working. If it doesn't appear in the new Temple+ dictionary (which is what MapToFeat does), then it uses the old hardcoded vanilla mapping. This points to the old, un-extended CondStruct, hence why your python hooks won't work.

edit: like so

Code:

powerAttackExtender.MapToFeat(feat_power_attack)

Re. BAB, it's the intended way to check it, yes. You could also write a char_editor version of stat_base_get for special handling of stat_attack_bonus (which is more or less what goes on in the feat prereq checker).

 

I understand now. I had tried using MapToFeat() with extended feats but I had not been doing it right. That's why I went with the brute force method.

I just added a pull request that should fix the issues. Thanks for the help.

BTW: The DM menu is now opening up when pressing escape.

 

Is there an event that is triggered any time a spell is cast? I am adding a feat that should do something whenever a spell is cast.

 

I don't think there's a global event, but there are various d20 signals being sent that could possibly suit your purpose. What did you have in mind?

 

Thanks. I was looking for events not signals...

Could use S_Spell_Cast? Is that called before or after the spell casting logic is done?