Stormlord PrC

Hey @Pygmy, thanks for your Feedback

Just to be sure, that I understand your post correctly.

You tried to take your first level of Stormlord(your modified version) at level 6 and you did already fulfill all requirements (feats, alignment, spell levels) and you weren't able to take the level.

But after you did add the feat (again?) with the dm console you could take it?

 

https://github.com/GrognardsFromHel...es/rules/char_class/class038_stormlord.py#L86

That's the cause. obj.feats only returns the feats that are explicitly chosen, and does not include stuff granted by deities. Sorry for the confusion.
Sagenlicht you should change it so it loops with has_feat() on the list.

 

My bad will fix it today evening.

 

Fix is pushed.

@Pygmy, here is the fix, so you can use it locally for your version.

Code:

def ObjMeetsPrereqs( obj ):
    requiredFeats = [feat_weapon_focus_halfspear, feat_weapon_focus_shortspear, feat_weapon_focus_longspear, feat_weapon_focus_javelin]
    if obj.divine_spell_level_can_cast() < 3:
        return 0
    elif obj.stat_level_get(stat_save_fortitude) < 4:
        return 0
#    elif not obj.has_feat(feat_endurance): #not in the game currently
#        return 0
    elif not obj.has_feat(feat_great_fortitude):
        return 0
    elif not any(obj.has_feat(feat) for feat in requiredFeats):
        return 0
    return 1

 

Thanks all working perfectly now. I must say shocking morningstar looks rather like a van der Graaff generator (not rock band with one f).

 

Hmm, speaking of erythul. Do you think the weapon proficiency should be generally altered so it matches the patron deity? (Being that there is no Talos in ToWE)

 

I had simar thoughts as well Sitra. I am just unsure to what Deity it should be adapted as there is not a 100% fitting one.
I fully agree that if it gets adopted to a different deity, it should match its fav weapon.

 

What about making a new deity?

 

I was thinking of automatically adapting the requirements (and benefits?) to your character's deity for maximum flexibility. You can get that info from the engine IIRC, see Favored Soul.

 

Just to be sure we are on the same page, keep the alignment restrictions (CE, CN, NE) and then open it for all deities tha qualifiy for those alignments (cleric deity is allowed to be one step away from the cleric alignment).

I've allready looked into the favored weapon thing with the spell Weapon of the Deity, though I stopped working on that spell as I had no chance to do item enchantments back then and postponed it. Though I still hope, I somehow get an item.condition.remove for this

The changes are pretty simple. I would keep the Javelin thing, if everyone agrees.

Code:

    objDeity = obj.get_deity()
    deityFavWeapon = game.get_deity_favored_weapon(objDeity)
    wfFavWeapon = feat_weapon_focus_gauntlet + deityFavWeapon
    wfList = [feat_weapon_focus_javelin, wfFavWeapon]
    if obj.divine_spell_level_can_cast() < 3:
        return 0
    elif obj.stat_level_get(stat_save_fortitude) < 4:
        return 0
#    elif not obj.has_feat(feat_endurance): #not in the game currently
#        return 0
    elif not obj.has_feat(feat_great_fortitude):
        return 0
    elif not any(obj.has_feat(feat) for feat in wfList):
        return 0
    return 1

Though Fav Soul uses

Code:

omg = obj.obj_get_int(obj_f_critter_deity)

unsure if get_deity() was implemented afterwards or obj_get_int is preferable

and in the stormlord.py:
replace the function:

Code:

## Define Stormlord Weapons; list can be extended if ever necessary ##
def stormlordWeapons():
    weaponList = [wt_javelin, wt_longspear, wt_shortspear, wt_spear]
    return weaponList

With

Code:

def stormlordWeapons():
    stormlordDeity = attachee.get_deity()
    deityFavWeapon = game.get_deity_favored_weapon(stormlordDeity)
    weaponList = [wt_javelin, deityFavWeapon]
    return weaponList

 

This looks really great Sagenlicht. I can quite understand what you say about keeping the javelin stuff as is; on a personal basis I have chosen otherwise, but am prepared to accept the untidyness of the caption of the class to hit bonus still referencing javelin as it involves a specific named feat.

 

Pretty much. Though maybe it'd be more correct to enforce CE deity.
About fav weapon, is it spear for Talos? I couldn't find any info on him for 3.5ed.

Also the last function needs attachee arg.

Not sure get_deity is any different than getting obj_f_deity but usually it's better to use the more abstract API.

 

I think so, https://forgottenrealms.fandom.com/wiki/Talos lists as fav Weapon a bunch of Spears

Fixed

oki.
Will push the changes after lunch

Edit: Hmm over read the CE Part.

 

Oki about the CE part. I don't think that deity alignment is exposed to python atm (correct me if I am wrong).

Which means the only solution that works right now would be a hard coded list. If this is fine, I'll add it

This is ofc no problem as long as no new deities or pantheons are added.

Edit:

Code:

def ObjMeetsPrereqs( obj ):
    objDeity = obj.get_deity()
    deityFavWeapon = game.get_deity_favored_weapon(objDeity)
    wfFavWeapon = feat_weapon_focus_gauntlet + deityFavWeapon
    wfList = [feat_weapon_focus_javelin, wfFavWeapon]
    deityList = [DEITY_ERYTHNUL, DEITY_GRUUMSH]
    if obj.divine_spell_level_can_cast() < 3:
        return 0
    elif obj.stat_level_get(stat_save_fortitude) < 4:
        return 0
#    elif not obj.has_feat(feat_endurance): #not in the game currently
#        return 0
    elif not obj.has_feat(feat_great_fortitude):
        return 0
    elif not any(obj.has_feat(feat) for feat in wfList):
        return 0
    elif not objDeity in deityList:
        return 0
    return 1

 

No, I definitely don't want to hardcode the deities, this should be retrieved from the game engine. Should be easy to add.