Vanilla Proto Issues

So, I've been silently hacking away at ToEE again for a while, and while rewriting the entire proto parser, I came across a bunch of issues with vanilla protos (not Co8, I mean pure Vanilla Patch 2 goodness).
Some of these have long been known, others, I am not so sure of. In this threat, I'd like to ask for your opinions on whether these should actually be fixed, even if they don't have any real impact (other than producing alot of log spam if ToEE were to validate the protos).

Invalid item_wear_flags
This one I have seen for almost every weapon. The following values are not valid item_wear_flags:

1. OIF_WEAR_WEAPON_PRIMARY [Determining whether something can be equipped in main/off-hand is handled differently, not using these flags]
   
2. OIF_WEAR_WEAPON_SECONDARY
3. OWF_TWO_HANDED (Proto 4064, 4065, 4106, 4203, 4204, 4217, 4221 have this flag) [Looks still present in Co8], should be OIF_WEAR_2HAND_REQUIRED instead
   
4. OIF_WEAR_RING_PRIMARY and OIF_WEAR_RING_SECONDARY (Lots of protos, only OIF_WEAR_RING is recognized)
   
5. "OIF_WEAR_AMMO," (Simple typo, Protos 5004, 5008) [Looks fixed in Co8]

Invalid String Condition Arguments
If a condition argument is a string, it has to be put into single quotes, otherwise it is not going to be stored as an ELFHash.
[w] Proto 4133 has bare text 'ef-Balor Sword' as condition argument. Should use single quotes.
In this particular case it means the sword is missing the balor sword particle system. Fix is to put the string in single quotes. [Co8 still has this error]

Unrecognized Critter Flags
L0oots of protos have unrecognized critter flags that are actually monster subtypes (probably Arkanum leftover??, this is handled via monster categories now)
Unrecognized flags:
OCF_ANIMAL
OCF_UNDEAD
OCF_PLANT
OCF_AIR
OCF_EARTH
OCF_FIRE
OCF_WATER
Seems pretty inconsequential.

Misc:
[w] Proto 2073 has invalid value for flags: 'OF_WATER_WALKING'
There's OSF_WATER_WALKING, which is a spell flag and not a flag, so this is bogus (and ignored anyway).

[w] Proto 3003 has invalid value for model_scale: .25
Scale is in percent, so this is shit and should be 25. [Co8 still has this value]

[w] Proto 14228 has invalid deity 'Beory'

[w] Proto 14264 has invalid value for npc_flags: 'ONF_ALOOF'
(and many more). ONF_ALOOF is not a valid NPC flag. Probably an Arkanum leftover.

 

item_wear_flags - I KNEW it! I dropped these flags from my mind blades in places because I was getting no effect on primary/secondary with them. It would be nice to deprecate them so people aren't fooled and waste their time trying to make something work in a way that will never work.

string conditions - Where exactly in code I write would this come up? Do you have an example? I enforce the convention on myself of always using double quotes for strings, never single quotes.

Otherwise I'm of the mindset of it would be nice to fix all of the issues if possible. Getting rid of the inconsequential log spam can help narrow down log spam that matters more. I have noticed a lot of log errors whenever I debug with temple+ related to validating or being unable to find files in vanilla and co8.

 

@WinstonShnozwick At least in the vanilla proto this only seems to affect the balor sword and the particle system name passed to the "Item Particle System" condition. In the C/C++ code, it'll apply ELFHash to anything that is in single quotes, and store the hash in the condition args. If it's not quoted though, it'll just "bork" and store 0.

I'll run my validation code against the current Co8 protos.tab as well. I have to get a clean install going first, though

 

I wouldn't waste time fixing imconsequential stuff. The Balor sword effect would be a nice fix I think (I guess no one has ever seen it?)

 

Well, I want to fix even the inconsequential stuff so it doesn't spam my logfile
The reasoning is this: In general I'd like to print warnings about misspelled or unknown flags.
However, here's what I propose: I produce a fixing tool that can automatically fix 99% of the problems for a given protos.tab
I think that's necessary because I want a fixed (non-co8) protos.tab, but also be able to fix the Co8 protos.tab with as little effort as possible.
I'll look into doing that soon, but we should decide *how* we should fix certain things.

For example: the creatures incorrectly flagged as OCF_UNDEAD, do we want to validate that they have the right monster category?

 

Alright, for Vanilla, I've found the following fixable issues:
https://gist.github.com/shartte/a0d87e4c2894d7359a342d817a5cdfb4

I've added a check for the critter flags against the monster type/subtype. I.e. OCF_AIR vs. mc_subtype_air and printed warnings if they don't match. Per the rules, I think it doesnt matter. If a "fiendishly huge viper" is classified as a magical beast, anything animal related would NOT apply to it anymore, right?

Current fixes my Python script applies:

• Remove OIF_WEAR_WEAPON_PRIMARY
• Remove OIF_WEAR_WEAPON_SECONDARY
• Remove OIF_WEAR_RING_PRIMARY
• Remove OIF_WEAR_RING_SECONDARY
• Remove OCF_ANIMAL
• Remove OCF_UNDEAD
• Remove OCF_PLANT
• Remove OCF_AIR
• Remove OCF_EARTH
• Remove OCF_FIRE
• Remove OCF_WATER

The only thing I don't know how to fix: WTF is up with the Beory deity. Should that just be old faith?


(p.s.: Python script is here: https://gist.github.com/shartte/d4c1cb9fdc43805e7b23739117825a12 - needs Python 3.6)

 

Good to know I haven't been doing anything that could cause this to be a problem.

 

How do you check the files, what validator?

 

@Rana271: I have a C# implementation in a yet unreleased reimplementation of temple.dll in C#

 

I also have c# proto parser))
Anyways - https://github.com/anatoliy-savchak/ToEE.Cormyr/blob/dev/data/rules/protos/proto_wands.tab I exported and updated wands to have 50 charges as in DMG.
Also - https://github.com/anatoliy-savchak/ToEE.Cormyr/blob/dev/data/scr/const_proto_wands.py has these wands as constants.

Good job working on the protos @DarkStorm ! Perhaps you could export into separate files the protos that you have addressed (fixed)?