So, I've been silently hacking away at ToEE again for a while, and while rewriting the entire proto parser, I came across a bunch of issues with vanilla protos (not Co8, I mean pure Vanilla Patch 2 goodness). Some of these have long been known, others, I am not so sure of. In this threat, I'd like to ask for your opinions on whether these should actually be fixed, even if they don't have any real impact (other than producing alot of log spam if ToEE were to validate the protos). Invalid item_wear_flags This one I have seen for almost every weapon. The following values are not valid item_wear_flags: OIF_WEAR_WEAPON_PRIMARY [Determining whether something can be equipped in main/off-hand is handled differently, not using these flags] OIF_WEAR_WEAPON_SECONDARY OWF_TWO_HANDED (Proto 4064, 4065, 4106, 4203, 4204, 4217, 4221 have this flag) [Looks still present in Co8], should be OIF_WEAR_2HAND_REQUIRED instead OIF_WEAR_RING_PRIMARY and OIF_WEAR_RING_SECONDARY (Lots of protos, only OIF_WEAR_RING is recognized) "OIF_WEAR_AMMO," (Simple typo, Protos 5004, 5008) [Looks fixed in Co8] Invalid String Condition Arguments If a condition argument is a string, it has to be put into single quotes, otherwise it is not going to be stored as an ELFHash. [w] Proto 4133 has bare text 'ef-Balor Sword' as condition argument. Should use single quotes. In this particular case it means the sword is missing the balor sword particle system. Fix is to put the string in single quotes. [Co8 still has this error] Unrecognized Critter Flags L0oots of protos have unrecognized critter flags that are actually monster subtypes (probably Arkanum leftover??, this is handled via monster categories now) Unrecognized flags: OCF_ANIMAL OCF_UNDEAD OCF_PLANT OCF_AIR OCF_EARTH OCF_FIRE OCF_WATER Seems pretty inconsequential. Misc: [w] Proto 2073 has invalid value for flags: 'OF_WATER_WALKING' There's OSF_WATER_WALKING, which is a spell flag and not a flag, so this is bogus (and ignored anyway). [w] Proto 3003 has invalid value for model_scale: .25 Scale is in percent, so this is shit and should be 25. [Co8 still has this value] [w] Proto 14228 has invalid deity 'Beory' [w] Proto 14264 has invalid value for npc_flags: 'ONF_ALOOF' (and many more). ONF_ALOOF is not a valid NPC flag. Probably an Arkanum leftover.